feat(algebra/big_operators): sum_eq_zero_iff_of_nonpos #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Sep 9, 2019
src/algebra/ordered_group.lean
Outdated
| @@ -132,6 +132,12 @@ iff.intro | |||
| lemma bit0_pos {a : α} (h : 0 < a) : 0 < bit0 a := | |||
| add_pos' h h | |||
|
|
|||
| instance : ordered_comm_monoid (order_dual α) := | |||
There was a problem hiding this comment.
Could you please also add an instance for ordered_comm_group?
jcommelin
approved these changes
Sep 9, 2019
jcommelin
added
the
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…mmunity#1424) * feat(algebra/big_operators): sum_eq_zero_iff_of_nonpos * more order_dual instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list