Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(algebra/*/colimits): avoid explicit infer_instance #1430

Merged
merged 3 commits into from Sep 11, 2019

Conversation

urkud
Copy link
Member

@urkud urkud commented Sep 10, 2019

With an explicit universe level Lean can do it automatically.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

With an explicit universe level Lean can do it automatically.
@urkud urkud requested a review from a team as a code owner September 10, 2019 16:04
@semorrison
Copy link
Collaborator

Looks good to me, lets merge!

@fpvandoorn fpvandoorn added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 10, 2019
@mergify mergify bot merged commit 8a5156f into leanprover-community:master Sep 11, 2019
@urkud urkud deleted the Mon-has-limits branch September 20, 2019 01:10
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…community#1430)

With an explicit universe level Lean can do it automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants