Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits): preserves biproducts if comparison is iso #14419

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(category_theory/limits): preserves biproducts if comparison is iso #14419

wants to merge 5 commits into from

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented May 27, 2022

Open in Gitpod

@TwoFX TwoFX added the awaiting-review The author would like community review of the PR label May 27, 2022
b-mehta
b-mehta reviewed May 28, 2022
View reviewed changes
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me, but I'd prefer if someone else more familiar with preservation of biproducts could take a look too! Maybe @semorrison or @jcommelin?

src/category_theory/limits/preserves/shapes/biproducts.lean Outdated Show resolved Hide resolved
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 26, 2022
bors bot pushed a commit that referenced this pull request Jul 26, 2022
@TwoFX
feat(category_theory/limits): preserves biproducts if comparison is i…
740f557 
…so (#14419)
@bors
Copy link

bors bot commented Jul 26, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 26, 2022
@TwoFX
feat(category_theory/limits): preserves biproducts if comparison is i…
c4d273c 
…so (#14419)
@bors
Copy link

bors bot commented Jul 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits): preserves biproducts if comparison is iso [Merged by Bors] - feat(category_theory/limits): preserves biproducts if comparison is iso Jul 26, 2022
@bors bors bot closed this Jul 26, 2022
@bors bors bot deleted the biprod-comparison branch July 26, 2022 14:35
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
@TwoFX @bottine
feat(category_theory/limits): preserves biproducts if comparison is i…
b43cc57 
…so (leanprover-community#14419)
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
@TwoFX @robertylewis
feat(category_theory/limits): preserves biproducts if comparison is i…
eed4344 
…so (#14419)
khwilson pushed a commit that referenced this pull request Aug 2, 2022
@TwoFX @khwilson
feat(category_theory/limits): preserves biproducts if comparison is i…
d903a50 
…so (#14419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-mehta b-mehta b-mehta left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TwoFX @semorrison @b-mehta