[Merged by Bors] - feat(set_theory/cardinal/basic): improve docs on lift, add simp lemmas
#14596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
awaiting-review
eric-wieser
reviewed
Jun 7, 2022
eric-wieser
reviewed
Jun 7, 2022
eric-wieser
reviewed
Jun 7, 2022
There was a problem hiding this comment.
It would be great if we could teach the pretty-printer to handle this; perhaps with an @[pp_universes] attribute on lift.
Perhaps @kmill has some ideas here.
|
I didn't change the docs on |
This reverts commit 7f546ea.
|
Sorry, wrong PR. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
…emmas (#14596) We add some much needed documentation to the `cardinal.lift` API. We also mark a few extra lemmas with `simp`.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jun 15, 2022
…emmas (#14596) We add some much needed documentation to the `cardinal.lift` API. We also mark a few extra lemmas with `simp`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
lift, add simp lemmaslift, add simp lemmas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add some much needed documentation to the
cardinal.liftAPI. We also mark a few extra lemmas withsimp.