Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(set_theory/ordinal/basic): improve docs on lift, add simp lemmas #14599

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(set_theory/ordinal/basic): improve docs on lift, add simp lemmas #14599

wants to merge 3 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jun 7, 2022

This is pretty much the same thing as #14596, just on ordinal.lift instead of cardinal.lift.

Open in Gitpod

@vihdzp vihdzp added awaiting-review The author would like community review of the PR docs This PR is about documentation labels Jun 7, 2022
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 13, 2022
@vihdzp vihdzp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 13, 2022
@robertylewis
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jun 14, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed awaiting-review The author would like community review of the PR labels Jun 14, 2022
@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Jun 14, 2022
@vihdzp vihdzp added awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Jun 14, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 17, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Jun 17, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 17, 2022
@vihdzp
feat(set_theory/ordinal/basic): improve docs on lift, add simp le…
d21469e 
…mmas (#14599)

This is pretty much the same thing as #14596, just on `ordinal.lift` instead of `cardinal.lift`.
@bors
Copy link

bors bot commented Jun 17, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/ordinal/basic): improve docs on lift, add simp lemmas [Merged by Bors] - feat(set_theory/ordinal/basic): improve docs on lift, add simp lemmas Jun 17, 2022
@bors bors bot closed this Jun 17, 2022
@bors bors bot deleted the ordinal_lift_note branch June 17, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. docs This PR is about documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vihdzp @robertylewis @eric-wieser