[Merged by Bors] - feat(ring_theory/valuation/valuation_subring): define maximal ideal of valuation subring and provide basic API #14656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckoen
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Jun 9, 2022
…munity/mathlib into valuation_maximal
eric-wieser
reviewed
Jun 13, 2022
1 task
adamtopaz
reviewed
Jun 21, 2022
Vierkantor
reviewed
Jul 12, 2022
Vierkantor
added
awaiting-author
mckoen
added
awaiting-review
Vierkantor
approved these changes
Jul 15, 2022
eric-wieser
reviewed
Jul 15, 2022
eric-wieser
reviewed
Jul 15, 2022
eric-wieser
reviewed
Jul 15, 2022
eric-wieser
reviewed
Jul 15, 2022
eric-wieser
reviewed
Jul 15, 2022
eric-wieser
reviewed
Jul 15, 2022
eric-wieser
reviewed
Jul 15, 2022
eric-wieser
reviewed
Jul 15, 2022
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
jcommelin
reviewed
Jul 16, 2022
Co-authored-by: Johan Commelin <johan@commelin.net>
robertylewis
added
awaiting-author
mckoen
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
…of valuation subring and provide basic API (#14656) This PR defines the unique maximal ideal of a valuation subring as a subsemigroup of the field. We prove a few equivalent conditions for two valuations to be equivalent, and we use this to show two valuation subrings are equivalent iff they have the same maximal ideal. Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: jackmckoen <104791831+jackmckoen@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…of valuation subring and provide basic API (leanprover-community#14656) This PR defines the unique maximal ideal of a valuation subring as a subsemigroup of the field. We prove a few equivalent conditions for two valuations to be equivalent, and we use this to show two valuation subrings are equivalent iff they have the same maximal ideal. Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: jackmckoen <104791831+jackmckoen@users.noreply.github.com>
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
…of valuation subring and provide basic API (#14656) This PR defines the unique maximal ideal of a valuation subring as a subsemigroup of the field. We prove a few equivalent conditions for two valuations to be equivalent, and we use this to show two valuation subrings are equivalent iff they have the same maximal ideal. Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: jackmckoen <104791831+jackmckoen@users.noreply.github.com>
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
…of valuation subring and provide basic API (#14656) This PR defines the unique maximal ideal of a valuation subring as a subsemigroup of the field. We prove a few equivalent conditions for two valuations to be equivalent, and we use this to show two valuation subrings are equivalent iff they have the same maximal ideal. Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: jackmckoen <104791831+jackmckoen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines the unique maximal ideal of a valuation subring as a subsemigroup of the field. We prove a few equivalent conditions for two valuations to be equivalent, and we use this to show two valuation subrings are equivalent iff they have the same maximal ideal.