Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(order/pfilter): more principal API #14759

Closed
wants to merge 11 commits into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Jun 15, 2022

principal and Inf form a Galois coinsertion.


I'm running a project on filters at Imperial and was just doing some Lean experiments to make sure I understood them properly.

Open in Gitpod

@kbuzzard kbuzzard added the awaiting-review The author would like community review of the PR label Jun 15, 2022
Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please apply the suggestions and then feel free to merge.

bors d+

src/order/pfilter.lean Outdated Show resolved Hide resolved
src/order/pfilter.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 17, 2022

✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 17, 2022
kbuzzard and others added 3 commits June 17, 2022 23:21
Co-authored-by: Oliver Nash <github@olivernash.org>
Co-authored-by: Oliver Nash <github@olivernash.org>
@kbuzzard
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 18, 2022
`principal` and `Inf` form a Galois coinsertion.
@bors
Copy link

bors bot commented Jun 18, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/pfilter): more principal API [Merged by Bors] - chore(order/pfilter): more principal API Jun 18, 2022
@bors bors bot closed this Jun 18, 2022
@bors bors bot deleted the kbuzzard/pfilter_API branch June 18, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants