Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(algebra/order/monoid): use typeclasses instead of lemmas #14848

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 20, 2022

Use covariant_class/contravariant_class instead of type-specific mul_le_mul_left etc lemmas. Also, rewrite some proofs to use API about inequalities on with_top/with_bot instead of the exact form of the current definition.


Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 20, 2022
@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 24, 2022
bors bot pushed a commit that referenced this pull request Jun 24, 2022
…4848)

Use `covariant_class`/`contravariant_class` instead of type-specific `mul_le_mul_left` etc lemmas. Also, rewrite some proofs to use API about inequalities on `with_top`/`with_bot` instead of the exact form of the current definition.
@bors
Copy link

bors bot commented Jun 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(algebra/order/monoid): use typeclasses instead of lemmas [Merged by Bors] - refactor(algebra/order/monoid): use typeclasses instead of lemmas Jun 24, 2022
@bors bors bot closed this Jun 24, 2022
@bors bors bot deleted the YK-with-zero-covconv branch June 24, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants