[Merged by Bors] - chore(data/nat,int): move field-specific lemmas about cast #14890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vierkantor
added
awaiting-review
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
3 tasks
github-actions
bot
removed
the
awaiting-CI
This was referenced Jun 22, 2022
Closed
Vierkantor
force-pushed
the
split-cast-div
branch
from
d50bf4f
to
0d8ea09
Compare
Vierkantor
added
the
awaiting-CI
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.basic`. This is the first step in rearranging those imports: remove the definition of a field from the dependencies of the casts `ℕ → α` and `ℤ → α`, where `α` is a (semi)ring.
Vierkantor
force-pushed
the
split-cast-div
branch
from
d1c359f
to
f74cc75
Compare
github-actions
bot
removed
the
awaiting-CI
|
Any reason to merge |
These lemmas were in #14849 split off from src/algebra/group_power/lemmas.lean and src/algebra/group_with_zero/power.lean. In that PR @eric-wieser suggested that they could be merged here when the dependencies have been readjusted. |
|
Thanks! bors merge |
github-actions
bot
added
the
ready-to-merge
github-actions
bot
removed
the
awaiting-review
bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.basic`. This is a step in rearranging those imports: remove the definition of a field from the dependencies of the casts `ℕ → α` and `ℤ → α`, where `α` is a (semi)ring.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Vierkantor
added a commit
that referenced
this pull request
Jun 27, 2022
In #14894, I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.basic`. Apparently this dependency was re-added, so I'm going to have to split it again...
bors bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
In #14894, I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.defs`. Apparently this dependency was re-added, so I'm going to have to split it again...
xroblot
pushed a commit
that referenced
this pull request
Jun 27, 2022
In #14894, I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.defs`. Apparently this dependency was re-added, so I'm going to have to split it again...
awainverse
pushed a commit
that referenced
this pull request
Jun 28, 2022
In #14894, I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.defs`. Apparently this dependency was re-added, so I'm going to have to split it again...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to refer to the rational numbers in the definition of a field, meaning we can't have
algebra.field.basicin the transitive imports ofdata.rat.basic.This is a step in rearranging those imports: remove the definition of a field from the dependencies of the casts
ℕ → αandℤ → α, whereαis a (semi)ring.