[Merged by Bors] - chore(data/int/cast): redo #14890, moving field-specific lemmas #14995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #14894, I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.basic`. Apparently this dependency was re-added, so I'm going to have to split it again...
Vierkantor
added
awaiting-review
3 tasks
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
Vierkantor
removed
the
awaiting-CI
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
In #14894, I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.defs`. Apparently this dependency was re-added, so I'm going to have to split it again...
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
xroblot
pushed a commit
that referenced
this pull request
Jun 27, 2022
In #14894, I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.defs`. Apparently this dependency was re-added, so I'm going to have to split it again...
awainverse
pushed a commit
that referenced
this pull request
Jun 28, 2022
In #14894, I want to refer to the rational numbers in the definition of a field, meaning we can't have `algebra.field.basic` in the transitive imports of `data.rat.defs`. Apparently this dependency was re-added, so I'm going to have to split it again...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #14894, I want to refer to the rational numbers in the definition of a field, meaning we can't have
algebra.field.basicin the transitive imports ofdata.rat.defs.Apparently this dependency was re-added, so I'm going to have to split it again...