Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(analysis/normed/field/basic): add @[simp] to `real.norm_eq_abs #15006

Closed
wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 27, 2022

  • mark real.norm_eq_abs and abs_nonneg as simp lemmas;
  • add abs versions of is_o.norm_left etc;
  • add inner_product_geometry.angle_smul_smul and linear_isometry.angle_map.

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 27, 2022
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

src/measure_theory/function/l1_space.lean Outdated Show resolved Hide resolved
src/measure_theory/function/l1_space.lean Outdated Show resolved Hide resolved
src/measure_theory/function/l1_space.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 5, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

urkud and others added 3 commits July 5, 2022 08:22
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@urkud urkud added the delegated The PR author may merge after reviewing final suggestions. label Jul 5, 2022
@urkud
Copy link
Member Author

urkud commented Jul 5, 2022

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 5, 2022
bors bot pushed a commit that referenced this pull request Jul 5, 2022
#15006)

* mark `real.norm_eq_abs` and `abs_nonneg` as `simp` lemmas;
* add `abs` versions of `is_o.norm_left` etc;
* add `inner_product_geometry.angle_smul_smul` and `linear_isometry.angle_map`.
@bors
Copy link

bors bot commented Jul 5, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 5, 2022
#15006)

* mark `real.norm_eq_abs` and `abs_nonneg` as `simp` lemmas;
* add `abs` versions of `is_o.norm_left` etc;
* add `inner_product_geometry.angle_smul_smul` and `linear_isometry.angle_map`.
@bors
Copy link

bors bot commented Jul 6, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/normed/field/basic): add @[simp] to `real.norm_eq_abs [Merged by Bors] - chore(analysis/normed/field/basic): add @[simp] to `real.norm_eq_abs Jul 6, 2022
@bors bors bot closed this Jul 6, 2022
@bors bors bot deleted the YK-real-norm-eq-abs branch July 6, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants