Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/asymptotics/asymptotics): generalize, golf #15010

Closed
wants to merge 14 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 27, 2022

  • add is_o_iff_nat_mul_le, is_o_iff_nat_mul_le', is_o_irrefl, is_O.not_is_o, is_o.not_is_O;
  • generalize lemmas about 1 = o(f), 1 = O(f), f = o(1), f = O(1) to [has_one F] [norm_one_class F], add some @[simp] attrs;
  • rename is_O_one_of_tendsto to filter.tendsto.is_O_one;
  • golf some proofs

Open in Gitpod

@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jun 27, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 6, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

@urkud urkud added the awaiting-review The author would like community review of the PR label Jul 7, 2022
@@ -143,10 +143,14 @@ theorem is_o.is_O (hgf : f =o[l] g) : f =O[l] g := hgf.is_O_with.is_O

lemma is_O.is_O_with : f =O[l] g → ∃ c : ℝ, is_O_with c l f g := is_O_iff_is_O_with.1

theorem is_O_with.weaken' (h : is_O_with c l f g) (hg : ∀ᶠ x in l, 0 ≤ ∥g x∥) (hc : c ≤ c') :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the point of stating things assuming only has_norm and assumptions saying some norms are non negative.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one result of this kind and renamed it to *_aux. It is used to prove two versions of a lemma assuming has_norm/semi_normed_group for different types.

@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 12, 2022
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 13, 2022
@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 14, 2022
bors bot pushed a commit that referenced this pull request Jul 14, 2022
* add `is_o_iff_nat_mul_le`, `is_o_iff_nat_mul_le'`, `is_o_irrefl`, `is_O.not_is_o`, `is_o.not_is_O`;
* generalize lemmas about `1 = o(f)`, `1 = O(f)`, `f = o(1)`, `f = O(1)` to `[has_one F] [norm_one_class F]`, add some `@[simp]` attrs;
* rename `is_O_one_of_tendsto` to `filter.tendsto.is_O_one`;
* golf some proofs
@bors
Copy link

bors bot commented Jul 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/asymptotics/asymptotics): generalize, golf [Merged by Bors] - feat(analysis/asymptotics/asymptotics): generalize, golf Jul 15, 2022
@bors bors bot closed this Jul 15, 2022
@bors bors bot deleted the YK-is-oO branch July 15, 2022 00:53
joelriou pushed a commit that referenced this pull request Jul 23, 2022
* add `is_o_iff_nat_mul_le`, `is_o_iff_nat_mul_le'`, `is_o_irrefl`, `is_O.not_is_o`, `is_o.not_is_O`;
* generalize lemmas about `1 = o(f)`, `1 = O(f)`, `f = o(1)`, `f = O(1)` to `[has_one F] [norm_one_class F]`, add some `@[simp]` attrs;
* rename `is_O_one_of_tendsto` to `filter.tendsto.is_O_one`;
* golf some proofs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants