chore(analysis/normed_space/linear_isometry): generalize submodule.subtypeL
#15115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemyDegenne
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Jul 5, 2022
Comment on lines
235
to
+240
| /-- `submodule.subtype` as a `continuous_linear_map`. -/ | ||
| def subtypeL : p →L[R'] E := p.subtypeₗᵢ.to_continuous_linear_map | ||
| def subtypeL {E : Type*} [add_comm_monoid E] [topological_space E] [module R' E] | ||
| (p : submodule R' E) : p →L[R'] E := | ||
| { to_fun := λ f, f, | ||
| map_add' := λ f g, rfl, | ||
| map_smul' := λ c f, rfl, } |
There was a problem hiding this comment.
Can you move this out of the normed_space folder and closer to continuous_linear_map?
eric-wieser
added
awaiting-author
|
|
|
Yep, #15700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
semi_normed_group Ehypothesis ofsubmodule.subtypeLby the weaker[add_comm_monoid E] [topological_space E].