[Merged by Bors] - chore(topology/algebra/module, analysis/normed_space/linear_isometry): dedup submodule.subtypeL and continuous_linear_map.subtype_val
#15700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADedecker
added
easy
3 tasks
eric-wieser
reviewed
Jul 26, 2022
eric-wieser
approved these changes
Jul 26, 2022
|
✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
added
the
awaiting-CI
leanprover-community-bot-assistant
added
delegated
github-actions
bot
removed
the
awaiting-CI
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
…: dedup `submodule.subtypeL` and `continuous_linear_map.subtype_val` (#15700) To designate the continuous linear inclusion of a submodule into the ambient space, we currently have both `continuous_linear_map.subtype_val` (correct assumptions, name not consistent with `submodule.subtype`) and `submodule.subtypeL` (good name, but way too strong assumptions). This keeps the best of both worlds.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
submodule.subtypeL and continuous_linear_map.subtype_valsubmodule.subtypeL and continuous_linear_map.subtype_val
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…: dedup `submodule.subtypeL` and `continuous_linear_map.subtype_val` (leanprover-community#15700) To designate the continuous linear inclusion of a submodule into the ambient space, we currently have both `continuous_linear_map.subtype_val` (correct assumptions, name not consistent with `submodule.subtype`) and `submodule.subtypeL` (good name, but way too strong assumptions). This keeps the best of both worlds.
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
…: dedup `submodule.subtypeL` and `continuous_linear_map.subtype_val` (#15700) To designate the continuous linear inclusion of a submodule into the ambient space, we currently have both `continuous_linear_map.subtype_val` (correct assumptions, name not consistent with `submodule.subtype`) and `submodule.subtypeL` (good name, but way too strong assumptions). This keeps the best of both worlds.
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
…: dedup `submodule.subtypeL` and `continuous_linear_map.subtype_val` (#15700) To designate the continuous linear inclusion of a submodule into the ambient space, we currently have both `continuous_linear_map.subtype_val` (correct assumptions, name not consistent with `submodule.subtype`) and `submodule.subtypeL` (good name, but way too strong assumptions). This keeps the best of both worlds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To designate the continuous linear inclusion of a submodule into the ambient space, we currently have both
continuous_linear_map.subtype_val(correct assumptions, name not consistent withsubmodule.subtype) andsubmodule.subtypeL(good name, but way too strong assumptions). This keeps the best of both worlds.