chore(linear_algebra): rename type variables #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abentkamp
added
help-wanted
rwbarton
changed the title
|
I've just updated |
sgouezel
reviewed
Oct 8, 2019
src/linear_algebra/basic.lean
Outdated
| @@ -56,303 +56,305 @@ open function lattice | |||
| reserve infix ` ≃ₗ `:25 | |||
|
|
|||
| universes u v w x y z | |||
| variables {α : Type u} {β : Type v} {γ : Type w} {δ : Type y} {ε : Type z} {ι : Type x} | |||
| variables {R κ : Type u} {M V : Type v} {M₂ V₂ : Type w} {M₃ V₃ : Type y} {M₄ : Type z} {ι : Type x} | |||
There was a problem hiding this comment.
Why are there variables in the same universe, instead of one universe for each variable? This seems to be calling for trouble...
There was a problem hiding this comment.
They should never mix. R replaced α in module defs/theorems, κ for vector spaces.
There was a problem hiding this comment.
Until someone writes in this file a statement with R and κ and doesn't pay attention to the fact that they belong to the same universe...
There was a problem hiding this comment.
Oh, fair enough. I was thinking in terms of faithfully translating the old file. Updated -- this should be safe in both respects.
robertylewis
added
awaiting-review
|
I think the only outstanding issue here is that we're not standardized on |
|
FWIW I prefer |
|
I don't think we really care. In the analysis folder, switching to |
|
This change is not 100% syntactic. The order of arguments seems to be permuted in six declarations. As far as we can tell, this is all that's happened, there are no unified universe levels. So I'll merge now, and note the alpha-normalized diff here (thanks @rwbarton ) for future reference. |
robertylewis
removed
the
awaiting-review
robertylewis
added
the
ready-to-merge
robertylewis
approved these changes
Oct 10, 2019
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
* doc(linear_algebra/basis): add doc * doc(linear_algebra/basis): shorten docstrings * refactor(linear_algebra/basis): rename type vars * style(linear_algebra/basic): change variable names * chore(linear_algebra/dimension): rename type variables * remove commented code * style(linear_algebra/bilinear_form): change variable names * style(linear_algebra/direct_sum_module): change variable names * style(linear_algebra/matrix): change variable names * Rename variables in finsupp_vector_space.lean * style(linear_algebra/sesquilinear_form): change variable names * style(linear_algebra/tensor_product): change variable names * change kappas to bb k's * style(linear_algebra/finsupp): change variable names * change universe levels * change bb k to K
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the type variables in linear algebra from greek letters to
Rfor rings𝕜for fieldsMfor modulesV/Efor vector spaces