Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/etale): Formally étale morphisms. #15242

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(ring_theory/etale): Formally étale morphisms. #15242

wants to merge 7 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jul 11, 2022

Open in Gitpod

@erdOne erdOne mentioned this pull request Jul 11, 2022
Closed
2 tasks
@erdOne erdOne added the awaiting-review The author would like community review of the PR label Jul 11, 2022
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 18, 2022
@jcommelin jcommelin requested a review from kbuzzard July 18, 2022 11:16
@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 18, 2022
jcommelin
jcommelin approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tiny docstring formatting fix

bors d+

src/ring_theory/etale.lean Outdated Show resolved Hide resolved
src/ring_theory/etale.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 19, 2022

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 19, 2022
@erdOne @jcommelin
Apply suggestions from code review
cf8e141 
Co-authored-by: Johan Commelin <johan@commelin.net>
@erdOne
Copy link
Member Author

erdOne commented Jul 19, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 19, 2022
@erdOne
feat(ring_theory/etale): Formally étale morphisms. (#15242)
1b775c2 


Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/etale): Formally étale morphisms. [Merged by Bors] - feat(ring_theory/etale): Formally étale morphisms. Jul 19, 2022
@bors bors bot closed this Jul 19, 2022
@bors bors bot deleted the formally_etale branch July 19, 2022 13:05
joelriou pushed a commit that referenced this pull request Jul 23, 2022
@erdOne @joelriou
feat(ring_theory/etale): Formally étale morphisms. (#15242)
bdbf197 


Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobrasca riccardobrasca riccardobrasca left review comments

@jcommelin jcommelin jcommelin approved these changes

@kbuzzard kbuzzard Awaiting requested review from kbuzzard

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erdOne @jcommelin @riccardobrasca @leanprover-community-bot-assistant