Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory): Formally étale/smooth/unramified morphisms are stable under base change. #15243

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat(ring_theory): Formally étale/smooth/unramified morphisms are stable under base change. #15243

wants to merge 8 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jul 11, 2022 •
edited by github-actions bot
Loading

@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 11, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 19, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@erdOne erdOne added the awaiting-review The author would like community review of the PR label Jul 20, 2022
@riccardobrasca riccardobrasca changed the title feat(ring_theory): Formally étale morphisms are stable under base change. feat(ring_theory): Formally étale/smooth/unramified morphisms are stable under base change. Jul 22, 2022
@riccardobrasca
Copy link
Member

I've edited the title to include formally smooth/unramified, but LGTM.

@jcommelin
Copy link
Member

Can you please also express this in terms of the "properties of morphism stabilities" language that you've been setting up?

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 27, 2022
@erdOne
Copy link
Member Author

erdOne commented Jul 27, 2022

These are currently all stated in terms of algebras. There will be a predicate on morphisms later, and it will come with that PR.

@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 27, 2022
@jcommelin
Copy link
Member

Ok. Looking forward to that PR (-;

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 27, 2022
bors bot pushed a commit that referenced this pull request Jul 27, 2022
@erdOne
feat(ring_theory): Formally étale/smooth/unramified morphisms are sta…
b4f242f 
…ble under base change. (#15243)
@bors
Copy link

bors bot commented Jul 27, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory): Formally étale/smooth/unramified morphisms are stable under base change. [Merged by Bors] - feat(ring_theory): Formally étale/smooth/unramified morphisms are stable under base change. Jul 27, 2022
@bors bors bot closed this Jul 27, 2022
@bors bors bot deleted the formally_etale_base_change branch July 27, 2022 17:02
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
@erdOne @bottine
feat(ring_theory): Formally étale/smooth/unramified morphisms are sta…
87d4ac0 
…ble under base change. (leanprover-community#15243)
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
@erdOne @robertylewis
feat(ring_theory): Formally étale/smooth/unramified morphisms are sta…
bfa7353 
…ble under base change. (#15243)
khwilson pushed a commit that referenced this pull request Aug 2, 2022
@erdOne @khwilson
feat(ring_theory): Formally étale/smooth/unramified morphisms are sta…
9bb48ee 
…ble under base change. (#15243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian-Kuelshammer Julian-Kuelshammer Julian-Kuelshammer left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erdOne @mathlib-dependent-issues-bot @riccardobrasca @jcommelin @Julian-Kuelshammer