Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/rel_iso): relation embeddings for sum.lex and prod.lex #15355

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(order/rel_iso): relation embeddings for sum.lex and prod.lex #15355

wants to merge 5 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jul 14, 2022

Open in Gitpod

@vihdzp vihdzp added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 14, 2022
eric-wieser
eric-wieser reviewed Jul 14, 2022
View reviewed changes
src/order/rel_iso.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 14, 2022
@vihdzp vihdzp mentioned this pull request Jul 15, 2022
Open
2 tasks
Vierkantor
Vierkantor approved these changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 1, 2022
bors bot pushed a commit that referenced this pull request Aug 1, 2022
@vihdzp
feat(order/rel_iso): relation embeddings for sum.lex and prod.lex (…
7200c50 
…#15355)
@bors
Copy link

bors bot commented Aug 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/rel_iso): relation embeddings for sum.lex and prod.lex [Merged by Bors] - feat(order/rel_iso): relation embeddings for sum.lex and prod.lex Aug 1, 2022
@bors bors bot closed this Aug 1, 2022
@bors bors bot deleted the rel_embedding_inl branch August 1, 2022 15:32
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
@vihdzp @robertylewis
feat(order/rel_iso): relation embeddings for sum.lex and prod.lex (…
58b8f80 
…#15355)
khwilson pushed a commit that referenced this pull request Aug 2, 2022
@vihdzp @khwilson
feat(order/rel_iso): relation embeddings for sum.lex and prod.lex (…
00f9781 
…#15355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vihdzp @eric-wieser @Vierkantor @leanprover-community-bot-assistant