Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(order/initial_seg): initial and principal segments for sum.lex and prod.lex #15368

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

feat(order/initial_seg): initial and principal segments for sum.lex and prod.lex #15368

wants to merge 21 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jul 15, 2022 •
edited

@vihdzp vihdzp added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jul 15, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 1, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@fpvandoorn fpvandoorn added the t-order Order hierarchy label Sep 28, 2022
@vihdzp vihdzp added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Jan 20, 2023
YaelDillies
YaelDillies approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open a matching mathlib4 PR?

@eric-wieser
Copy link
Member

Can you merge master to fix the conflicts? Can any of this be golfed using @negiizhao's recent work?

@eric-wieser eric-wieser added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 31, 2023
@vihdzp
Copy link
Collaborator Author

vihdzp commented Apr 1, 2023

I don't believe @negiizhao's work is particularly relevant for these specific lemmas. Master has been merged.

@vihdzp vihdzp removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 5, 2023
@eric-wieser eric-wieser added the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees

@digama0 digama0

Labels
awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vihdzp @mathlib-dependent-issues-bot @eric-wieser @YaelDillies @digama0 @fpvandoorn