Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/initial_seg): Initial/principal segment from empty type #15375

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(order/initial_seg): Initial/principal segment from empty type #15375

wants to merge 9 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jul 15, 2022 •
edited by github-actions bot

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jul 15, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jul 15, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@vihdzp vihdzp added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 17, 2022
@fpvandoorn
Copy link
Member

Thanks

bors d+

@bors
Copy link

bors bot commented Jul 21, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 21, 2022
@vihdzp vihdzp added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 21, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 21, 2022
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 21, 2022
bors bot pushed a commit that referenced this pull request Jul 21, 2022
@vihdzp
feat(order/initial_seg): Initial/principal segment from empty type (#…
9bf23b0 
…15375)
@bors
Copy link

bors bot commented Jul 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/initial_seg): Initial/principal segment from empty type [Merged by Bors] - feat(order/initial_seg): Initial/principal segment from empty type Jul 21, 2022
@bors bors bot closed this Jul 21, 2022
@bors bors bot deleted the initial_segment_of_empty branch July 21, 2022 22:10
joelriou pushed a commit that referenced this pull request Jul 23, 2022
@vihdzp @joelriou
feat(order/initial_seg): Initial/principal segment from empty type (#…
4b529da 
…15375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vihdzp @mathlib-dependent-issues-bot @fpvandoorn