[Merged by Bors] - chore(order/initial_seg): move definitions of initial and principal segments #15328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
the
awaiting-review
This was referenced Jul 15, 2022
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2022
…egments (#15328) We move the definitions of initial and principal segments from `set_theory/ordinal/basic.lean` to a new file `order/initial_seg.lean`. We minimally change this file, just doing the following: - add a copyright header - copy over existing documentation - add a few `noncomputable` attributes - localize the notation - use `by_cases` in `initial_seg.lt_or_eq` (needed as the `classical` locale is no longer open)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
joelriou
pushed a commit
that referenced
this pull request
Jul 23, 2022
…egments (#15328) We move the definitions of initial and principal segments from `set_theory/ordinal/basic.lean` to a new file `order/initial_seg.lean`. We minimally change this file, just doing the following: - add a copyright header - copy over existing documentation - add a few `noncomputable` attributes - localize the notation - use `by_cases` in `initial_seg.lt_or_eq` (needed as the `classical` locale is no longer open)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We move the definitions of initial and principal segments from
set_theory/ordinal/basic.leanto a new fileorder/initial_seg.lean. We minimally change this file, just doing the following:noncomputableattributesby_casesininitial_seg.lt_or_eq(needed as theclassicallocale is no longer open)This part of the file always seemed out of place to me.