Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(topology/continuous_on): avoid duplicate instance arguments #1542

Merged
merged 2 commits into from
Oct 12, 2019

Conversation

rwbarton
Copy link
Collaborator

This was broken by #1516, caught by sanity_check.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

This was broken by #1516, caught by sanity_check.
@rwbarton
Copy link
Collaborator Author

(Haven't tried building this locally yet.)

@rwbarton
Copy link
Collaborator Author

I confirmed locally that this builds and there are no more sanity check errors for topology.continuous_on.

@jcommelin jcommelin added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 12, 2019
@mergify mergify bot merged commit 92a9a78 into master Oct 12, 2019
@mergify mergify bot deleted the rwbarton-fix-continuous-on branch October 12, 2019 18:22
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants