Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/inner_product/pi_L2): a finite orthonormal family is a basis of its span #15481

Closed
wants to merge 16 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Jul 18, 2022

We actually prove this for finite sub-families of a generic orthonormal basis because this is easier to use in practice


Open in Gitpod

@ADedecker ADedecker added the awaiting-review The author would like community review of the PR label Jul 18, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 18, 2022
Copy link
Member Author

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(EDIT: mistake)

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
/-- Any finite subset of a orthonormal family is an `orthonormal_basis` for its span. -/
protected def span {v' : ι' → E} (h : orthonormal 𝕜 v') (s : finset ι') :
orthonormal_basis s 𝕜 (span 𝕜 (s.image v' : set E)) :=
let
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, could you write the proof in the same way as in basis.span, using orthonormal_basis.mk?

@hrmacbeth hrmacbeth added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 18, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 21, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

@hrmacbeth
Copy link
Member

hrmacbeth commented Jul 25, 2022

Please merge master and then merge yourself. Thanks!

bors +

@bors
Copy link

bors bot commented Jul 25, 2022

Did you mean "r+"?

@hrmacbeth
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jul 25, 2022

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Jul 25, 2022
@ADedecker
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 26, 2022
…basis of its span (#15481)

We actually prove this for finite sub-families of a generic orthonormal basis because this is easier to use in practice
@bors
Copy link

bors bot commented Jul 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/inner_product/pi_L2): a finite orthonormal family is a basis of its span [Merged by Bors] - feat(analysis/inner_product/pi_L2): a finite orthonormal family is a basis of its span Jul 26, 2022
@bors bors bot closed this Jul 26, 2022
@bors bors bot deleted the AD_orthonormal_basis_span branch July 26, 2022 23:25
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
…basis of its span (leanprover-community#15481)

We actually prove this for finite sub-families of a generic orthonormal basis because this is easier to use in practice
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
…basis of its span (#15481)

We actually prove this for finite sub-families of a generic orthonormal basis because this is easier to use in practice
khwilson pushed a commit that referenced this pull request Aug 2, 2022
…basis of its span (#15481)

We actually prove this for finite sub-families of a generic orthonormal basis because this is easier to use in practice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants