Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/inner_product_space/l2_space): compute orthogonal projection on U given a hilbert basis of U #15541

Closed
wants to merge 62 commits into from
Closed

[Merged by Bors] - feat(analysis/inner_product_space/l2_space): compute orthogonal projection on U given a hilbert basis of U #15541

wants to merge 62 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Jul 20, 2022 •
edited by github-actions bot
Loading

@ADedecker ADedecker added the WIP Work in progress label Jul 20, 2022
@ADedecker ADedecker mentioned this pull request Jul 20, 2022
Open
9 tasks
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 20, 2022
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jul 20, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 14, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@sgouezel
Copy link
Collaborator

Can you fix the lint?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 14, 2022
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 14, 2022
@ADedecker
Copy link
Member Author

Done!

sgouezel
sgouezel reviewed Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

src/analysis/inner_product_space/pi_L2.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 23, 2022

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 23, 2022
@ADedecker @sgouezel
Update src/analysis/inner_product_space/pi_L2.lean
83f1c06 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@ADedecker
Copy link
Member Author

bors r+

1 similar comment
@ADedecker
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 25, 2022
@ADedecker
feat(analysis/inner_product_space/l2_space): compute orthogonal proje…
1313934 
…ction on U given a hilbert basis of U (#15541)
@bors
Copy link

bors bot commented Sep 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/inner_product_space/l2_space): compute orthogonal projection on U given a hilbert basis of U [Merged by Bors] - feat(analysis/inner_product_space/l2_space): compute orthogonal projection on U given a hilbert basis of U Sep 25, 2022
@bors bors bot closed this Sep 25, 2022
@bors bors bot deleted the AD_proj_basis branch September 25, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

@hrmacbeth hrmacbeth hrmacbeth left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ADedecker @mathlib-dependent-issues-bot @sgouezel @hrmacbeth @leanprover-community-bot-assistant