Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(archive): add proof of sensitivity conjecture #1553

Merged
merged 14 commits into from Oct 22, 2019
Merged

Conversation

robertylewis
Copy link
Member

Moving the formalization from https://github.com/leanprover-community/lean-sensitivity to the mathlib archive.

This builds on #1550 which locates the lemmas from for_mathlib.lean throughout the library. When that's merged, I'll rebase the last commit here.

This is coauthored with @rwbarton @jcommelin @jesse-michael-han @ChrisHughes24 @PatrickMassot

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@jcommelin jcommelin added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 15, 2019
archive/sensitivity.lean Outdated Show resolved Hide resolved
archive/sensitivity.lean Outdated Show resolved Hide resolved
-- a natural number).
variable {n}

lemma succ_n_eq (p q : Q (n+1)) : p = q ↔ (p 0 = q 0 ∧ π p = π q) :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand this name... but eq_iff_fst_eq_and_proj_eq is very verbose.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not really important, but I'm not sure what to call it. Your suggestion is very long.

archive/sensitivity.lean Outdated Show resolved Hide resolved
archive/sensitivity.lean Outdated Show resolved Hide resolved
archive/sensitivity.lean Outdated Show resolved Hide resolved
archive/sensitivity.lean Outdated Show resolved Hide resolved
@bryangingechen bryangingechen removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 22, 2019
@semorrison
Copy link
Collaborator

Looks good. Shall we merge?

@robertylewis
Copy link
Member Author

Patrick did a nice job of making this presentable over the summer, so I suspect there's not much more work to be done.

@robertylewis robertylewis added the awaiting-review The author would like community review of the PR label Oct 22, 2019
@semorrison semorrison added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 22, 2019
@mergify mergify bot merged commit 93b1786 into master Oct 22, 2019
@mergify mergify bot deleted the sensitivity_archive branch October 22, 2019 12:22
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…ity#1553)

* feat(*): various lemmas from the sensitivity project

* fix proof broken by nonterminal simp

* Update src/linear_algebra/dual.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* lint dual.lean

* remove decidable_mem_of_fintype instance

this leads to loops with `subtype.fintype` under the right decidable_eq assumptions

* dual_lc is invalid simp lemma

* fix namespace

* add extra lemma

* feat(archive): add proof of sensitivity conjecture

* suggestions from Johan

* undo removed whitespace

* update header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants