Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/inner_product_space): in finite dimension, hilbert basis = orthonormal basis #15540

Closed
wants to merge 8 commits into from

Conversation

ADedecker
Copy link
Member

This allows transferring general facts about hilbert bases to orthonormal bases


Open in Gitpod

@ADedecker ADedecker added the awaiting-review The author would like community review of the PR label Jul 20, 2022
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 20, 2022
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 20, 2022
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find these ever so slightly cleaner, otherwise this looks good to me!

src/analysis/inner_product_space/l2_space.lean Outdated Show resolved Hide resolved
src/analysis/inner_product_space/l2_space.lean Outdated Show resolved Hide resolved
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Copy link
Member

@hrmacbeth hrmacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/analysis/inner_product_space/l2_space.lean Outdated Show resolved Hide resolved
src/analysis/inner_product_space/l2_space.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 25, 2022

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 25, 2022
@ADedecker
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 26, 2022
…s = orthonormal basis (#15540)

This allows transferring general facts about hilbert bases to orthonormal bases
@bors
Copy link

bors bot commented Jul 27, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/inner_product_space): in finite dimension, hilbert basis = orthonormal basis [Merged by Bors] - feat(analysis/inner_product_space): in finite dimension, hilbert basis = orthonormal basis Jul 27, 2022
@bors bors bot closed this Jul 27, 2022
@bors bors bot deleted the AD_hilbert_orthonormal branch July 27, 2022 00:09
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
…s = orthonormal basis (leanprover-community#15540)

This allows transferring general facts about hilbert bases to orthonormal bases
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
…s = orthonormal basis (#15540)

This allows transferring general facts about hilbert bases to orthonormal bases
khwilson pushed a commit that referenced this pull request Aug 2, 2022
…s = orthonormal basis (#15540)

This allows transferring general facts about hilbert bases to orthonormal bases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants