-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(*): Rename normed_group
to normed_add_comm_group
#15619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should mention that normed_add_group_hom
was renamed too
normed_group
to normed_add_group
normed_group
to normed_add_comm_group
nondiscrete_normed_field → nontrivially_normed_field
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2022
* `normed_group` → `normed_add_comm_group` * `semi_normed_group` → `seminormed_add_comm_group`. Elision of the underscore corresponds to `seminorm` (and to counterbalance the name being sensibly longer). * `normed_group_hom` → `normed_add_group_hom`
Pull request successfully merged into master. Build succeeded: |
normed_group
to normed_add_comm_group
normed_group
to normed_add_comm_group
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…r-community#15619) * `normed_group` → `normed_add_comm_group` * `semi_normed_group` → `seminormed_add_comm_group`. Elision of the underscore corresponds to `seminorm` (and to counterbalance the name being sensibly longer). * `normed_group_hom` → `normed_add_group_hom`
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
* `normed_group` → `normed_add_comm_group` * `semi_normed_group` → `seminormed_add_comm_group`. Elision of the underscore corresponds to `seminorm` (and to counterbalance the name being sensibly longer). * `normed_group_hom` → `normed_add_group_hom`
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
* `normed_group` → `normed_add_comm_group` * `semi_normed_group` → `seminormed_add_comm_group`. Elision of the underscore corresponds to `seminorm` (and to counterbalance the name being sensibly longer). * `normed_group_hom` → `normed_add_group_hom`
ocfnash
pushed a commit
to leanprover-community/sphere-eversion
that referenced
this pull request
Aug 9, 2022
Most of the changes from the following Mathlib PRs: leanprover-community/mathlib#15619 chore(*): Rename normed_group to normed_add_comm_group leanprover-community/mathlib#15625 refactor(*): rename nondiscrete_normed_field leanprover-community/mathlib#15632 feat(order/filter/*): filter.pi is countably generated leanprover-community/mathlib#15634 feat(topology/metric_space/lipschitz): add several lemmas leanprover-community/mathlib#15627 fix(*): fix typos I made yesterday leanprover-community/mathlib#15523 feat(geometry/manifold/smooth_manifold_with_corners): properties to prove smoothness of mfderiv leanprover-community/mathlib#15640 chore(topology/locally_finite): move from topology.basic
ocfnash
added a commit
to leanprover-community/sphere-eversion
that referenced
this pull request
Sep 12, 2022
Most of the changes from the following Mathlib PRs: leanprover-community/mathlib#15619 chore(*): Rename normed_group to normed_add_comm_group leanprover-community/mathlib#15625 refactor(*): rename nondiscrete_normed_field leanprover-community/mathlib#15632 feat(order/filter/*): filter.pi is countably generated leanprover-community/mathlib#15634 feat(topology/metric_space/lipschitz): add several lemmas leanprover-community/mathlib#15627 fix(*): fix typos I made yesterday leanprover-community/mathlib#15523 feat(geometry/manifold/smooth_manifold_with_corners): properties to prove smoothness of mfderiv leanprover-community/mathlib#15640 chore(topology/locally_finite): move from topology.basic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normed_group
→normed_add_comm_group
semi_normed_group
→seminormed_add_comm_group
. Elision of the underscore corresponds toseminorm
(and to counterbalance the name being sensibly longer).normed_group_hom
→normed_add_group_hom
Zulip: