Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/filter/*): filter.pi is countably generated #15632

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 23, 2022

  • rename filter.has_basis_infi to filter.has_basis_infi', add new filter.has_basis_infi;
  • move prod.is_countably_generated, golf, add coprod.is_countably_generated;
  • is_countably_generated_seq is no longer an instance, infi.is_countably_generated is better;
  • add infi.is_countably_generated and pi.is_countably_generated;
  • prove prod.fist_countable_topology (from the sphere eversion project) and pi.first_countable_topology;
  • generalize pi.second_countable_topology from encodable to countable so that it automatically applies to finite types.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 23, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 23, 2022
@urkud urkud added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jul 24, 2022
@urkud urkud added this to In progress in Sphere eversion project via automation Jul 24, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Jul 26, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 26, 2022
bors bot pushed a commit that referenced this pull request Jul 26, 2022
* rename `filter.has_basis_infi` to `filter.has_basis_infi'`, add new `filter.has_basis_infi`;
* move `prod.is_countably_generated`, golf, add `coprod.is_countably_generated`;
* `is_countably_generated_seq` is no longer an instance, `infi.is_countably_generated` is better;
* add `infi.is_countably_generated` and `pi.is_countably_generated`;
* prove `prod.fist_countable_topology` (from the sphere eversion project) and `pi.first_countable_topology`;
* generalize `pi.second_countable_topology` from `encodable` to `countable` so that it automatically applies to finite types.
@bors
Copy link

bors bot commented Jul 26, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 26, 2022
* rename `filter.has_basis_infi` to `filter.has_basis_infi'`, add new `filter.has_basis_infi`;
* move `prod.is_countably_generated`, golf, add `coprod.is_countably_generated`;
* `is_countably_generated_seq` is no longer an instance, `infi.is_countably_generated` is better;
* add `infi.is_countably_generated` and `pi.is_countably_generated`;
* prove `prod.fist_countable_topology` (from the sphere eversion project) and `pi.first_countable_topology`;
* generalize `pi.second_countable_topology` from `encodable` to `countable` so that it automatically applies to finite types.
@bors
Copy link

bors bot commented Jul 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/filter/*): filter.pi is countably generated [Merged by Bors] - feat(order/filter/*): filter.pi is countably generated Jul 26, 2022
@bors bors bot closed this Jul 26, 2022
Sphere eversion project automation moved this from In progress to Done Jul 26, 2022
@bors bors bot deleted the YK-countably-generated-pi branch July 26, 2022 12:57
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
…community#15632)

* rename `filter.has_basis_infi` to `filter.has_basis_infi'`, add new `filter.has_basis_infi`;
* move `prod.is_countably_generated`, golf, add `coprod.is_countably_generated`;
* `is_countably_generated_seq` is no longer an instance, `infi.is_countably_generated` is better;
* add `infi.is_countably_generated` and `pi.is_countably_generated`;
* prove `prod.fist_countable_topology` (from the sphere eversion project) and `pi.first_countable_topology`;
* generalize `pi.second_countable_topology` from `encodable` to `countable` so that it automatically applies to finite types.
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
* rename `filter.has_basis_infi` to `filter.has_basis_infi'`, add new `filter.has_basis_infi`;
* move `prod.is_countably_generated`, golf, add `coprod.is_countably_generated`;
* `is_countably_generated_seq` is no longer an instance, `infi.is_countably_generated` is better;
* add `infi.is_countably_generated` and `pi.is_countably_generated`;
* prove `prod.fist_countable_topology` (from the sphere eversion project) and `pi.first_countable_topology`;
* generalize `pi.second_countable_topology` from `encodable` to `countable` so that it automatically applies to finite types.
khwilson pushed a commit that referenced this pull request Aug 2, 2022
* rename `filter.has_basis_infi` to `filter.has_basis_infi'`, add new `filter.has_basis_infi`;
* move `prod.is_countably_generated`, golf, add `coprod.is_countably_generated`;
* `is_countably_generated_seq` is no longer an instance, `infi.is_countably_generated` is better;
* add `infi.is_countably_generated` and `pi.is_countably_generated`;
* prove `prod.fist_countable_topology` (from the sphere eversion project) and `pi.first_countable_topology`;
* generalize `pi.second_countable_topology` from `encodable` to `countable` so that it automatically applies to finite types.
ocfnash pushed a commit to leanprover-community/sphere-eversion that referenced this pull request Aug 9, 2022
Most of the changes from the following Mathlib PRs:
leanprover-community/mathlib#15619 chore(*): Rename normed_group to normed_add_comm_group
leanprover-community/mathlib#15625 refactor(*): rename nondiscrete_normed_field
leanprover-community/mathlib#15632 feat(order/filter/*): filter.pi is countably generated
leanprover-community/mathlib#15634 feat(topology/metric_space/lipschitz): add several lemmas
leanprover-community/mathlib#15627 fix(*): fix typos I made yesterday
leanprover-community/mathlib#15523 feat(geometry/manifold/smooth_manifold_with_corners): properties to prove smoothness of mfderiv
leanprover-community/mathlib#15640 chore(topology/locally_finite): move from topology.basic
ocfnash added a commit to leanprover-community/sphere-eversion that referenced this pull request Sep 12, 2022
Most of the changes from the following Mathlib PRs:
leanprover-community/mathlib#15619 chore(*): Rename normed_group to normed_add_comm_group
leanprover-community/mathlib#15625 refactor(*): rename nondiscrete_normed_field
leanprover-community/mathlib#15632 feat(order/filter/*): filter.pi is countably generated
leanprover-community/mathlib#15634 feat(topology/metric_space/lipschitz): add several lemmas
leanprover-community/mathlib#15627 fix(*): fix typos I made yesterday
leanprover-community/mathlib#15523 feat(geometry/manifold/smooth_manifold_with_corners): properties to prove smoothness of mfderiv
leanprover-community/mathlib#15640 chore(topology/locally_finite): move from topology.basic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-topology Topological spaces, uniform spaces, metric spaces, filters
Development

Successfully merging this pull request may close these issues.

None yet

2 participants