Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(algebra/group): conversion between →* and →+ #1569

Merged
merged 5 commits into from Oct 22, 2019
Merged

feat(algebra/group): conversion between →* and →+ #1569

merged 5 commits into from Oct 22, 2019

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 19, 2019

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

jcommelin
jcommelin reviewed Oct 19, 2019
View reviewed changes
src/algebra/group/type_tags.lean Outdated Show resolved Hide resolved
src/algebra/group/type_tags.lean Outdated Show resolved Hide resolved
@semorrison
Copy link
Collaborator

What do you need this for?

A rfl-lemma you might state is that these operations preserve the (coerced) function.

@urkud
Copy link
Member Author

urkud commented Oct 22, 2019

What do you need this for?

I needed a composition g ∘ f, where g : α →+ β and f : multiplicative β →* γ.

@jcommelin jcommelin added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 22, 2019
@mergify mergify bot merged commit e8bdb05 into master Oct 22, 2019
@mergify mergify bot deleted the mult-monoid-hom branch October 22, 2019 14:31
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@urkud @anrddh
feat(algebra/group): conversion between →* and →+ (leanprover-com…
5f9e7e2 
…munity#1569)

* feat(algebra/group): conversion between `→*` and `→+`

* docs

* Rename to allow use of projection notation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@semorrison semorrison semorrison approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @semorrison @jcommelin