Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data/finset): inj_on_of_surj_on_of_card_le #1578

Merged
merged 5 commits into from
Oct 22, 2019
Merged

feat(data/finset): inj_on_of_surj_on_of_card_le #1578

merged 5 commits into from
Oct 22, 2019

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Oct 21, 2019 •
edited

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

jcommelin
jcommelin reviewed Oct 21, 2019
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that this proof needs 16 lines. But I don't see how to compress it.
Could you please add the dual statement, surj_on_of_inj_on?

src/data/finset.lean Outdated Show resolved Hide resolved
@ChrisHughes24
Copy link
Member Author

I'm surprised that this proof needs 16 lines. But I don't see how to compress it.
Could you please add the dual statement, surj_on_of_inj_on?

The dual is already there

@jcommelin
Copy link
Member

Aah, sorry. I didn't check the file.

@robertylewis
Copy link
Member

A mostly irrelevant stylistic point, but it might look cleaner if you open the function namespace. Or are those lemmas protected?

@semorrison semorrison added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 21, 2019
@mergify mergify bot merged commit 340178d into master Oct 22, 2019
@mergify mergify bot deleted the ChrisHughes24-patch-1 branch October 22, 2019 00:57
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@ChrisHughes24 @anrddh
feat(data/finset): inj_on_of_surj_on_of_card_le (leanprover-community…
a373df2 
…#1578)

* feat(data/finset): inj_on_of_surj_on_of_card_le

* Type ascriptions

* function namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@semorrison semorrison semorrison approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChrisHughes24 @jcommelin @robertylewis @semorrison