Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/convex/cone): lemmas about inner_dual_cone of unions #15836

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(analysis/convex/cone): lemmas about inner_dual_cone of unions #15836

wants to merge 7 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Aug 3, 2022 •
edited
Loading

This discards the proof in #15639 and replaces it with a more general strategy and some auxiliary lemmas.

This includes an insert lemma for consistency with submodule.span_insert, even though it follows trivially from the union lemma.

Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Aug 3, 2022
@eric-wieser eric-wieser mentioned this pull request Aug 3, 2022
Closed
@eric-wieser eric-wieser mentioned this pull request Aug 3, 2022
Closed
2 tasks
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 3, 2022
@eric-wieser eric-wieser added the t-analysis Analysis (normed *, calculus) label Aug 3, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Aug 9, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 9, 2022
bors bot pushed a commit that referenced this pull request Aug 9, 2022
@eric-wieser
feat(analysis/convex/cone): lemmas about inner_dual_cone of unions (#…
3f1b43a 
…15836)

This discards the proof in #15639 and replaces it with a more general strategy and some auxiliary lemmas.

This includes an `insert` lemma for consistency with `submodule.span_insert`, even though it follows trivially from the union lemma.
@bors
Copy link

bors bot commented Aug 9, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 9, 2022
@eric-wieser
feat(analysis/convex/cone): lemmas about inner_dual_cone of unions (#…
1a51c70 
…15836)

This discards the proof in #15639 and replaces it with a more general strategy and some auxiliary lemmas.

This includes an `insert` lemma for consistency with `submodule.span_insert`, even though it follows trivially from the union lemma.
@bors
Copy link

bors bot commented Aug 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/convex/cone): lemmas about inner_dual_cone of unions [Merged by Bors] - feat(analysis/convex/cone): lemmas about inner_dual_cone of unions Aug 9, 2022
@bors bors bot closed this Aug 9, 2022
@bors bors bot deleted the eric-wieser/cone-union branch August 9, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdoll mcdoll mcdoll left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @ocfnash @mcdoll