-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linear_algebra/basis): Dedekind's linear independence of characters #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks beautiful! |
rwbarton
reviewed
Oct 23, 2019
rwbarton
added
the
awaiting-author
A reviewer has asked the author a question or requested changes
label
Oct 23, 2019
rwbarton
removed
the
awaiting-author
A reviewer has asked the author a question or requested changes
label
Oct 24, 2019
ChrisHughes24
approved these changes
Oct 26, 2019
ChrisHughes24
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Oct 26, 2019
Oops, I didn't see that you'd click ready to merge. I just committed some comments in the proof. |
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…ers (leanprover-community#1595) * feat(linear_algebra/basis): Dedekind's linear independence of characters * feat(linear_algebra/basis): generalize independence of characters to integral domains * chore(linear_algebra/basis): change proofs * commenting the proof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list