Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linear_algebra/basis): Dedekind's linear independence of characters #1595

Merged
merged 6 commits into from
Oct 26, 2019

Conversation

kckennylau
Copy link
Collaborator

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@semorrison
Copy link
Collaborator

Looks beautiful!

@rwbarton rwbarton added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 23, 2019
@ChrisHughes24 ChrisHughes24 self-assigned this Oct 23, 2019
@rwbarton rwbarton removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 24, 2019
@ChrisHughes24 ChrisHughes24 added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 26, 2019
@semorrison
Copy link
Collaborator

Oops, I didn't see that you'd click ready to merge. I just committed some comments in the proof.

@mergify mergify bot merged commit 8eaf478 into master Oct 26, 2019
@mergify mergify bot deleted the dedekind-indep branch October 26, 2019 12:59
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…ers (leanprover-community#1595)

* feat(linear_algebra/basis): Dedekind's linear independence of characters

* feat(linear_algebra/basis): generalize independence of characters to integral domains

* chore(linear_algebra/basis): change proofs

* commenting the proof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants