Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/group_with_zero): generalize some lemmas #15985

Closed
wants to merge 14 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 10, 2022

  • replace *_hom.map_inv by a generic lemma map_inv₀ assuming [monoid_with_zero_hom_class];
  • replace *_hom.map_div by a generic lemma map_div₀ assuming [monoid_with_zero_hom_class];
  • replace *_hom.map_zpow by a generic lemma map_zpow₀ assuming [monoid_with_zero_hom_class];
  • replace *_hom.map_units_inv by a generic lemma map_units_inv assuming [monoid_hom_class], [monoid], and [division_monoid].

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Aug 10, 2022
@urkud urkud added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Aug 10, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 14, 2022
@urkud urkud added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) and removed WIP Work in progress labels Aug 14, 2022
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 15, 2022
bors bot pushed a commit that referenced this pull request Aug 15, 2022
* replace `*_hom.map_inv` by a generic lemma `map_inv₀` assuming `[monoid_with_zero_hom_class]`;
* replace `*_hom.map_div` by a generic lemma `map_div₀` assuming `[monoid_with_zero_hom_class]`;
* replace `*_hom.map_zpow` by a generic lemma `map_zpow₀` assuming `[monoid_with_zero_hom_class]`;
* replace `*_hom.map_units_inv` by a generic lemma `map_units_inv` assuming `[monoid_hom_class]`, `[monoid]`, and `[division_monoid]`.
@bors
Copy link

bors bot commented Aug 15, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 15, 2022
* replace `*_hom.map_inv` by a generic lemma `map_inv₀` assuming `[monoid_with_zero_hom_class]`;
* replace `*_hom.map_div` by a generic lemma `map_div₀` assuming `[monoid_with_zero_hom_class]`;
* replace `*_hom.map_zpow` by a generic lemma `map_zpow₀` assuming `[monoid_with_zero_hom_class]`;
* replace `*_hom.map_units_inv` by a generic lemma `map_units_inv` assuming `[monoid_hom_class]`, `[monoid]`, and `[division_monoid]`.
@jcommelin
Copy link
Member

bors merge p=2

bors bot pushed a commit that referenced this pull request Aug 16, 2022
* replace `*_hom.map_inv` by a generic lemma `map_inv₀` assuming `[monoid_with_zero_hom_class]`;
* replace `*_hom.map_div` by a generic lemma `map_div₀` assuming `[monoid_with_zero_hom_class]`;
* replace `*_hom.map_zpow` by a generic lemma `map_zpow₀` assuming `[monoid_with_zero_hom_class]`;
* replace `*_hom.map_units_inv` by a generic lemma `map_units_inv` assuming `[monoid_hom_class]`, `[monoid]`, and `[division_monoid]`.
@bors
Copy link

bors bot commented Aug 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/group_with_zero): generalize some lemmas [Merged by Bors] - feat(algebra/group_with_zero): generalize some lemmas Aug 16, 2022
@bors bors bot closed this Aug 16, 2022
@bors bors bot deleted the YK-map-inv branch August 16, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants