[Merged by Bors] - chore(geometry/manifold/complex): extract some theory of locally constant functions #16019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2022
…tant functions (#16019) After #16015, I realised that we might as well deduce the rest of the lemmas in the file from the `is_locally_constant` lemma by appealing to general theory about locally constant functions. I have added three such lemmas to the general theory of locally constant functions: * `is_locally_constant.apply_eq_of_preconnected_space` * `is_locally_constant.eq_const` * `is_locally_constant.exists_eq_const` All are direct copies of the lemmas for the bundled version (`locally_constant`). Then I reworked the holomorphic function theory to pass through these, which cuts a few lines from the file.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #16015, I realised that we might as well deduce the rest of the lemmas in the file from the
is_locally_constantlemma by appealing to general theory about locally constant functions. I have added three such lemmas to the general theory of locally constant functions:is_locally_constant.apply_eq_of_preconnected_spaceis_locally_constant.eq_constis_locally_constant.exists_eq_constAll are direct copies of the lemmas for the bundled version (
locally_constant). Then I reworked the holomorphic function theory to pass through these, which cuts a few lines from the file.