Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data/nat/basic): remove pos_iff_ne_zero' #1610

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Conversation

rwbarton
Copy link
Collaborator

This used to be different from pos_iff_ne_zero because the latter
was phrased in terms of n > 0, not 0 < n. Since #1436 they
are the same.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

This used to be different from pos_iff_ne_zero because the latter
was phrased in terms of `n > 0`, not `0 < n`. Since #1436 they
are the same.
@jcommelin jcommelin added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 24, 2019
@mergify mergify bot merged commit 9db43a5 into master Oct 24, 2019
@mergify mergify bot deleted the pos_iff_ne_zero branch October 24, 2019 21:14
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…1610)

This used to be different from pos_iff_ne_zero because the latter
was phrased in terms of `n > 0`, not `0 < n`. Since leanprover-community#1436 they
are the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants