Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linear_algebra/basic): define algebra structure on endomorphisms of module #1618

Merged
merged 3 commits into from
Oct 27, 2019
Merged

feat(linear_algebra/basic): define algebra structure on endomorphisms of module #1618

merged 3 commits into from
Oct 27, 2019

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Oct 26, 2019

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion:
https://leanprover-community.github.io/archive/113489newmembers/03140endomorphismalgebra.html

For reviewers: code review check list

@bryangingechen
Copy link
Collaborator

Travis is complaining about a cyclic import so endomorphism_algebra should probably be moved to a different file, maybe ring_theory/algebra.lean? @jcommelin

@ChrisHughes24 ChrisHughes24 added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Oct 27, 2019
@ChrisHughes24 ChrisHughes24 self-assigned this Oct 27, 2019
@ocfnash
Copy link
Collaborator Author

ocfnash commented Oct 27, 2019

@bryangingechen 🤦‍♂ Thank you. I have moved the definition to ring_theory/algebra.lean (I poked around looking for better locations but couldn't see an obviously-preferable alternative). Let's see what Travis thinks this time!

@ChrisHughes24 ChrisHughes24 added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 27, 2019
@mergify mergify bot merged commit 1fa03c2 into leanprover-community:master Oct 27, 2019
@ocfnash ocfnash deleted the module_endomorphism_algebra branch October 28, 2019 09:15
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
… of module (leanprover-community#1618)

* feat(linear_algebra/basic): define algebra structure on endomorphisms of module

* Update algebra.lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants