chore(data/rat/defs): Shortcut instance for ring ℚ
#16349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
easy
eric-wieser
reviewed
Sep 3, 2022
| @@ -490,9 +490,8 @@ instance : is_domain ℚ := | |||
| .. (infer_instance : no_zero_divisors ℚ) } | |||
|
|
|||
| /- Extra instances to short-circuit type class resolution -/ | |||
There was a problem hiding this comment.
This should include a remark about computability like the instances for real have.
|
An alternative strategy would be to change |
|
#16463 will make this shortcut unnecessary |
@YaelDillies @eric-wieser Given that that has been merged, what should be done with this PR? |
|
Given Mario's todo, let's close this. |
YaelDillies
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncomment the
ring ℚinstance. This is needed to avoid computability poisoning as importinganalysis.normed.field.basiccurrently makes Lean infer the ring operations onℚfromrat.normed_field, which is noncomputable.Mario commented this instance in e53c2bb, claiming performance reasons, but I could not witness any sensible difference.
An option to respect Mario's comment and fix the noncomputability poisoning would be to declare the instance later than
data.real.basic, but that would be a confusing design.