[Merged by Bors] - refactor(data/real/basic): make ⊓ and ⊔ computable on reals
#16463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
WIP
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
Showing that these coincide with the max and min (respectively) of `real` is left to a follow-up PR. Note that these do not form a `distrib_lattice` as `cau_seq` does not form a `partial_order`.
…ic-wieser/real-computable-min
github-actions
bot
removed
the
awaiting-CI
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
…ic-wieser/real-computable-min
|
Why is |
Because I didn't want to make this PR grow any further, and had intended to leave that to a followup. My guess would be that it's because |
|
That feels like good enough justification to rename |
|
Another option would be to keep |
eric-wieser
added
the
awaiting-review
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
This also makes `norm` and `dist` computable on `real`, `nnreal`, `rat`, and `int`. From a mathematical point of view that doesn't care about computability, this still contains the (mildly) interesting result that the maximum of two reals is equal to the real produced by taking the elementwise maximum of the two cauchy sequences. This change causes some unpleasant elaboration pain in `modular.lean` for reasons presumably linked to unification of dependent typeclasses. It's not clear to me precisely what the cause if. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
⊓ and ⊔ computable on reals⊓ and ⊔ computable on reals
b-mehta
pushed a commit
that referenced
this pull request
Sep 21, 2022
This also makes `norm` and `dist` computable on `real`, `nnreal`, `rat`, and `int`. From a mathematical point of view that doesn't care about computability, this still contains the (mildly) interesting result that the maximum of two reals is equal to the real produced by taking the elementwise maximum of the two cauchy sequences. This change causes some unpleasant elaboration pain in `modular.lean` for reasons presumably linked to unification of dependent typeclasses. It's not clear to me precisely what the cause if. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes
normanddistcomputable onreal,nnreal,rat, andint.From a mathematical point of view that doesn't care about computability, this still contains the (mildly) interesting result that the maximum of two reals is equal to the real produced by taking the elementwise maximum of the two cauchy sequences.
This change causes some unpleasant elaboration pain in
modular.leanfor reasons presumably linked to unification of dependent typeclasses. It's not clear to me precisely what the cause if.min,max, andabs#16485distrib_latticeinstance #16493noncomputable theorywithnoncomputable#16552If the unification issues are particular cause for concern, then I could try to bisect to find which change is responsible.