Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sum_two_square): extract lemmas about primes in Z[i] #1643

Merged
merged 5 commits into from
Nov 5, 2019
Merged

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Nov 3, 2019

This file extracts lemmas from the proof of Fermat's two square theorem.

I prove that a natural number is a prime in Z[i] iff it is three mod four. Fermat's two square theorem is a trivial consequences of this theorem and other theorems proved on the way to this theorem.

I also added docs to the Gaussian integer file.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks unobjectionable to me, but I'll leave it open a bit longer in case anyone else has comments.

src/data/zsqrtd/gaussian_int.lean Show resolved Hide resolved
@robertylewis robertylewis added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 5, 2019
@mergify mergify bot merged commit 986e58c into master Nov 5, 2019
@mergify mergify bot deleted the Zi branch November 5, 2019 15:43
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…over-community#1643)

* refactor(sum_two_square): extract lemmas about primes in Z[i]

* forgot to save

* docztring

* module docstrings
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…over-community#1643)

* refactor(sum_two_square): extract lemmas about primes in Z[i]

* forgot to save

* docztring

* module docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants