Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(algebra/order): split files #16792

Closed
wants to merge 15 commits into from
Closed

chore(algebra/order): split files #16792

wants to merge 15 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Oct 4, 2022 •
edited by adomani

While reviewing what may need to be ported from mathlib before porting linarith, I thought that these file splits and import reductions would be useful in any case.

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-order Order hierarchy labels Oct 4, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 5, 2022
@semorrison semorrison force-pushed the semorrison/modularize_algebra_order branch from f3302eb to ad88f81 Compare October 5, 2022 22:33
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 6, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 6, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@semorrison semorrison added the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 6, 2022
@Vierkantor Vierkantor self-assigned this Oct 6, 2022
@Vierkantor
Copy link
Collaborator

The PR looks good overall to me and indeed it seems important to keep up to date with mathlib, so what I'll do is let you and Yaël discuss this.

bors d=@YaelDillies

bors d=@semorrison

@bors
Copy link

bors bot commented Oct 6, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented Oct 6, 2022

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 6, 2022
@semorrison
Copy link
Collaborator Author

Note to reviewers: this is waiting for revision after #16172 merges.

@semorrison semorrison mentioned this pull request Oct 8, 2022
Closed
1 task
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 8, 2022
@semorrison semorrison closed this Oct 8, 2022
bors bot pushed a commit that referenced this pull request Oct 9, 2022
@semorrison @YaelDillies
chore(algebra/order/monoid): split into smaller files (#16861)
8ef4f3f 
This, along later PRs for `algebra.order.group` and `algebra.order.ring`, will replace #16792.

- [x] depends on: #16172

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)


Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor left review comments

Assignees

@Vierkantor Vierkantor

Labels
delegated The PR author may merge after reviewing final suggestions. t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @mathlib-dependent-issues-bot @Vierkantor @alreadydone