Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(algebra/order/monoid): split into smaller files #16861

Closed
wants to merge 114 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Oct 8, 2022

This, along later PRs for algebra.order.group and algebra.order.ring, will replace #16792.

Open in Gitpod

@semorrison semorrison added awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Oct 8, 2022
@semorrison semorrison changed the title chore(algebra/order/monoid): split out with_{top|zero} chore(algebra/order/monoid): split into smaller files Oct 8, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 8, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 8, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this sort of change it's useful to use leancrawler to check that nothing really changed (e.g., like https://gist.github.com/ocfnash/4de274664fd7f0e605050d06abe0a57f).

However in this case I'm confident enough because so much depends on this and CI has passed. I spotted one typo but otherwise this LGTM.

bors d+

src/algebra/order/monoid/canonical.lean Outdated Show resolved Hide resolved
@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 9, 2022
@bors
Copy link

bors bot commented Oct 9, 2022

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

semorrison and others added 3 commits October 10, 2022 09:00
Co-authored-by: Oliver Nash <github@olivernash.org>
…anprover-community/mathlib into semorrison/split_algebra_order_monoid
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 9, 2022
bors bot pushed a commit that referenced this pull request Oct 9, 2022
This, along later PRs for `algebra.order.group` and `algebra.order.ring`, will replace #16792.

- [x] depends on: #16172

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)


Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@bors
Copy link

bors bot commented Oct 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/order/monoid): split into smaller files [Merged by Bors] - chore(algebra/order/monoid): split into smaller files Oct 10, 2022
@bors bors bot closed this Oct 10, 2022
@bors bors bot deleted the semorrison/split_algebra_order_monoid branch October 10, 2022 01:06
bors bot pushed a commit that referenced this pull request Oct 13, 2022

- [x] depends on: #16861

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)


Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants