[Merged by Bors] - feat(linear_algebra): the direct sum of a submodule quotient is the quotient of the direct sum #17069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uotient of the direct sum This defines the linear equivalence `submodule.quotient_pi` which allows us to interchange taking the direct sum and taking the quotient. This result is useful for defining the ideal norm. Co-Authored-By: Alex J. Best <alex.j.best@gmail.com>
Vierkantor
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Oct 20, 2022
eric-wieser
reviewed
Oct 20, 2022
eric-wieser
reviewed
Oct 20, 2022
| variables {N : Type*} [add_comm_group N] [module R N] | ||
| variables {Ns : ι → Type*} [∀ i, add_comm_group (Ns i)] [∀ i, module R (Ns i)] | ||
|
|
||
| /-- Lift a family of maps to the direct sum of quotients. -/ |
There was a problem hiding this comment.
Calling this a direct sum is maybe misleading in the presence of direct_sum... But I don't have a better suggestion
There was a problem hiding this comment.
I don't think the presence of direct_sum should change the informal meaning of "direct sum". :-)
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…t annoying timeouts due to the simp set not converging fast enough (?)
2 tasks
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
…uotient of the direct sum (#17069) This defines the linear equivalence `submodule.quotient_pi` which allows us to interchange taking the direct sum and taking the quotient. This result is useful for defining the ideal norm. Co-Authored-By: Alex J. Best <alex.j.best@gmail.com> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 12, 2022
…uotient of the direct sum (#17069) This defines the linear equivalence `submodule.quotient_pi` which allows us to interchange taking the direct sum and taking the quotient. This result is useful for defining the ideal norm. Co-Authored-By: Alex J. Best <alex.j.best@gmail.com> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines the linear equivalence
submodule.quotient_piwhich allows us to interchange taking the direct sum and taking the quotient. This result is useful for defining the ideal norm.Co-Authored-By: Alex J. Best alex.j.best@gmail.com