Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/module/composition_series): Jordan-Hölder for modules #17295

Closed
wants to merge 16 commits into from

Conversation

MadPidgeon
Copy link
Collaborator

@MadPidgeon MadPidgeon commented Nov 1, 2022

@MadPidgeon MadPidgeon added not-ready-to-merge t-algebra Algebra (groups, rings, fields etc) labels Nov 1, 2022
@YaelDillies YaelDillies changed the title feat(algebra/module): Add Jordan-Holder for modules feat(algebra/module/composition_series): Jordan-Hölder for modules Nov 2, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Nov 17, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

@MadPidgeon MadPidgeon added awaiting-review The author would like community review of the PR and removed not-ready-to-merge labels Nov 26, 2022
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Golfed the proofs a bit. I think it's ready to go!

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@dupuisf
Copy link
Collaborator

dupuisf commented Nov 27, 2022

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 27, 2022
@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Nov 27, 2022
bors bot pushed a commit that referenced this pull request Nov 27, 2022
…17295)




Co-authored-by: D.M.H. van Gent <gentdmhvan@u0031838.vuw.leidenuniv.nl>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@eric-wieser
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Nov 28, 2022
…17295)




Co-authored-by: D.M.H. van Gent <gentdmhvan@u0031838.vuw.leidenuniv.nl>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@bors
Copy link

bors bot commented Nov 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/module/composition_series): Jordan-Hölder for modules [Merged by Bors] - feat(algebra/module/composition_series): Jordan-Hölder for modules Nov 28, 2022
@bors bors bot closed this Nov 28, 2022
@bors bors bot deleted the jordan-holder-modules branch November 28, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants