New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(algebra/module/composition_series): Jordan-Hölder for modules #17295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadPidgeon
added
not-ready-to-merge
t-algebra
Algebra (groups, rings, fields etc)
labels
Nov 1, 2022
YaelDillies
changed the title
feat(algebra/module): Add Jordan-Holder for modules
feat(algebra/module/composition_series): Jordan-Hölder for modules
Nov 2, 2022
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
… jordan-holder-modules
mathlib-dependent-issues-bot
added
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
and removed
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
labels
Nov 17, 2022
This PR/issue depends on: |
MadPidgeon
added
awaiting-review
The author would like community review of the PR
and removed
not-ready-to-merge
labels
Nov 26, 2022
YaelDillies
approved these changes
Nov 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Golfed the proofs a bit. I think it's ready to go!
maintainer merge
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
bors r+ |
github-actions
bot
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Nov 27, 2022
github-actions
bot
removed
the
awaiting-review
The author would like community review of the PR
label
Nov 27, 2022
bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2022
…17295) Co-authored-by: D.M.H. van Gent <gentdmhvan@u0031838.vuw.leidenuniv.nl> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
…17295) Co-authored-by: D.M.H. van Gent <gentdmhvan@u0031838.vuw.leidenuniv.nl> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(algebra/module/composition_series): Jordan-Hölder for modules
[Merged by Bors] - feat(algebra/module/composition_series): Jordan-Hölder for modules
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
t-algebra
Algebra (groups, rings, fields etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #17226.