New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(order/cover): split to reduce imports #17340
Conversation
This does not seem like a particularly pertinent split. I cannot see any theme among the lemmas you split off except that they are about The only other idea I have is to split into |
The split is just "does this require all of finiteness or not". |
bors d+ |
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
Then your new file is misnamed 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me put this on hold because:
- This specific split is unmotivated in my opinion
- move(data/set/pointwise/interval): Sanitise imports #17347 should supersede it
Yaël, this isn't an unmotivated split, it is motivated by the porting effort. Nothing can be a stronger motivation. However if your alternative modification is better for porting then of course we can consider it. |
This doesn't have a giant effect by itself, but if we also split
order.atoms
to separate out the material aboutfintype
, we get more.