Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(order/cover): split to reduce imports #17340

Closed
wants to merge 3 commits into from
Closed

Conversation

semorrison
Copy link
Collaborator

This doesn't have a giant effect by itself, but if we also split order.atoms to separate out the material about fintype, we get more.


Open in Gitpod

@semorrison semorrison requested a review from a team as a code owner November 4, 2022 01:40
@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Nov 4, 2022
@YaelDillies
Copy link
Collaborator

This does not seem like a particularly pertinent split. I cannot see any theme among the lemmas you split off except that they are about covby. Can you move the ord_connected lemmas to data.set.intervals.ord_connected and leave the others where they are?

The only other idea I have is to split into order.cover.basic, order.cover.interval and order.cover.prod, but it's getting ridiculous for such a short file.

@semorrison
Copy link
Collaborator Author

The split is just "does this require all of finiteness or not".

@PatrickMassot
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Nov 4, 2022

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 4, 2022
@YaelDillies
Copy link
Collaborator

Then your new file is misnamed 😅

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me put this on hold because:

@PatrickMassot
Copy link
Member

Yaël, this isn't an unmotivated split, it is motivated by the porting effort. Nothing can be a stronger motivation. However if your alternative modification is better for porting then of course we can consider it.

@semorrison semorrison added the WIP Work in progress label Nov 4, 2022
@semorrison semorrison closed this Nov 6, 2022
@YaelDillies YaelDillies deleted the split_order_cover branch November 8, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-CI The author would like to see what CI has to say before doing more work. delegated The PR author may merge after reviewing final suggestions. WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants