move(data/set/pointwise/interval): Sanitise imports #17347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-CI
11 tasks
|
Great, thanks, this looks promising. I'll check if there's any value to #17340 after this merges. bors d+ |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
semorrison
reviewed
Nov 4, 2022
YaelDillies
commented
Nov 4, 2022
| @@ -3,6 +3,7 @@ Copyright (c) 2021 Yaël Dillies. All rights reserved. | |||
| Released under Apache 2.0 license as described in the file LICENSE. | |||
| Authors: Yaël Dillies | |||
| -/ | |||
| import data.fin.basic | |||
There was a problem hiding this comment.
Just noting for later: this import is bogus. I remember adding the few fin lemmas at the bottom of the file because that was the first place where I had both access to covby and fin (due to the bogus import this PR is fixing), but those lemmas have nothing to do with succ/pred on nat.
github-actions
bot
removed
the
awaiting-CI
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
Quite a lot of pure order theory files import `data.set.intervals.unordered_interval`, which itself imports `data.set.intervals.image_preimage`, which in turn imports a lot of algebra. If we change the order of dependency between `data.set.intervals.unordered_interval` and `data.set.intervals.image_preimage`, we avoid algebra leaking into pure order theory and drastically reduce imports for many files. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed (retrying...): |
|
Canceled. |
|
There was a merge conflict with master, unfortunately. bors merge p=25 |
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
Quite a lot of pure order theory files import `data.set.intervals.unordered_interval`, which itself imports `data.set.intervals.image_preimage`, which in turn imports a lot of algebra. If we change the order of dependency between `data.set.intervals.unordered_interval` and `data.set.intervals.image_preimage`, we avoid algebra leaking into pure order theory and drastically reduce imports for many files. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed: |
semorrison
added
awaiting-CI
|
This is going to merged as part of #17381. I'm closing now to conserve CI resources. |
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
This is the supremum of * #17376 * #17375 * #17374 * #17362 * #17355 * #17349 * #17347 * #17338 * #17336 with imports fixed up to accommodate all the overlapping changes to imports. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
This is the supremum of * #17376 * #17375 * #17374 * #17362 * #17355 * #17349 * #17347 * #17338 * #17336 with imports fixed up to accommodate all the overlapping changes to imports. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a lot of pure order theory files import
data.set.intervals.unordered_interval, which itself importsdata.set.intervals.image_preimage, which in turn imports a lot of algebra.If we change the order of dependency between
data.set.intervals.unordered_intervalanddata.set.intervals.image_preimage, we avoid algebra leaking into pure order theory and drastically reduce imports for many files.@semorrison, I expect this makes #17340 useless.