Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(measure_theory/bochner_integration): linearity of the Bochner Integral #1745

Merged
merged 11 commits into from Nov 29, 2019

Conversation

aceg00
Copy link
Collaborator

@aceg00 aceg00 commented Nov 26, 2019

This PR proves integral_zero integral_add integral_sub and integral_smul,

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@sgouezel
Copy link
Collaborator

I imagine it would be a good idea to make integral irreducible at the end of this file, once the API is set up: otherwise, whenever Lean will see an integral (which will happen in a lot of different places), it might try to unfold everything all the way down to the uniform extension of a continuous linear map defined on the space of simple functions, and it might slow down things a bit. What do you think?

@sgouezel
Copy link
Collaborator

I know that Johan has requested simp attributes, but I am not so sure about this: I imagine that we will have complicated integrals and that we will want to make simplifications in the integrand. Splitting the integral into many integrals seems to go in the opposite direction -- it might be useful sometimes, especially when there is a formula for the integral of some part of the integrand, but not always. @jcommelin, what do you think?

@jcommelin
Copy link
Member

@sgouezel Fair enough, that's a good point. So how about make the integrand-simp-lemmas high priority, and the ones in this PR low priority? Or maybe put these lemmas in a special simp-set, that doesn't get used by default. I think I like that best. It's better to err on the safe side (-;

@sgouezel
Copy link
Collaborator

Yes, a specific simp set is a good idea. Simp priorities don't work very well, as they only play a role when there are two lemmas to be applied at the same stage, but a low priority lemma can be applied earlier, deeper in the expression.

@aceg00
Copy link
Collaborator Author

aceg00 commented Nov 27, 2019

How do I put lemmas into a simp-set?

@PatrickMassot
Copy link
Member

See the very end of https://leanprover.github.io/theorem_proving_in_lean/tactics.html#using-the-simplifier

@sgouezel sgouezel added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 29, 2019
@mergify mergify bot merged commit 817711d into leanprover-community:master Nov 29, 2019
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…tegral (leanprover-community#1745)

* Linearity of the Bochner Integral

* prove integral_neg and integral_smul with less assumptions; make integral irreducible

* remove simp tag

* create simp set for integral

* Add simp_attr.integral to nolint

* Make it possible to unfold the definition of `integral`

and other things.

* Update nolints.txt

* Make it possible to unfold l1.integral

* Update bochner_integration.lean

* Update bochner_integration.lean
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…tegral (leanprover-community#1745)

* Linearity of the Bochner Integral

* prove integral_neg and integral_smul with less assumptions; make integral irreducible

* remove simp tag

* create simp set for integral

* Add simp_attr.integral to nolint

* Make it possible to unfold the definition of `integral`

and other things.

* Update nolints.txt

* Make it possible to unfold l1.integral

* Update bochner_integration.lean

* Update bochner_integration.lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants