refactor(analysis/specific_limits): use ennreals instead of nnreals in *_edist_le_geometric
#1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
the
blocked-by-other-PR
Merged
4 tasks
urkud
force-pushed
the
edist-geometric
branch
from
52f0ffd
to
46b75c5
Compare
I tried to actually use `nnreal`s, and it leads to coercions nightmare.
urkud
force-pushed
the
edist-geometric
branch
from
947528b
to
6f3fa6d
Compare
urkud
removed
the
blocked-by-other-PR
sgouezel
reviewed
Dec 16, 2019
sgouezel
reviewed
Dec 16, 2019
sgouezel
added
the
ready-to-merge
sgouezel
approved these changes
Dec 17, 2019
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…`s in `*_edist_le_geometric` (leanprover-community#1759) * feat(data/real/ennreal): more lemmas, `*_cast` tags, use `lift` tactic * Undo name change * Fix compile * nnreal: add `move_cast` * ennreal: more lemmas * Fix compile * feat(topology/instances/ennreal): more lemmas * Fix compile * Rewrite `cauchy_seq_of_edist_le_geometric` etc in terms of `ennreal`s I tried to actually use `nnreal`s, and it leads to coercions nightmare. * Simplify some proofs using new lemmas * Fix compile * Fix compile
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…`s in `*_edist_le_geometric` (leanprover-community#1759) * feat(data/real/ennreal): more lemmas, `*_cast` tags, use `lift` tactic * Undo name change * Fix compile * nnreal: add `move_cast` * ennreal: more lemmas * Fix compile * feat(topology/instances/ennreal): more lemmas * Fix compile * Rewrite `cauchy_seq_of_edist_le_geometric` etc in terms of `ennreal`s I tried to actually use `nnreal`s, and it leads to coercions nightmare. * Simplify some proofs using new lemmas * Fix compile * Fix compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1755, #1756
I tried to migrate
closedsfromhalf_powto the newcauchy_seq_of_edist_le_geometricbut proving the required inequalities withnnreals require a lot ofcasting thatnorm_castcan't handle. So, useennreals right away.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list