Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(algebra/field_power): fpow is a strict mono #1778

Merged
merged 10 commits into from
Dec 7, 2019

Conversation

jcommelin
Copy link
Member

From the perfectoid project.
Depends on #1777.

A field homomorphism is just a ring homomorphism.
This is one trivial tiny step in moving over to bundled homs.
@jcommelin jcommelin added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 4, 2019
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Dec 5, 2019
src/algebra/field_power.lean Outdated Show resolved Hide resolved
src/algebra/field_power.lean Outdated Show resolved Hide resolved
@fpvandoorn
Copy link
Member

The Travis build seems to time-out (but without clear reason). I rebased to restart Travis

@fpvandoorn fpvandoorn added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 7, 2019
@mergify mergify bot merged commit 3c9f8f0 into master Dec 7, 2019
@mergify mergify bot deleted the field-power-strict-mono branch December 7, 2019 17:49
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…y#1778)

* WIP

* feat(algebra/field): remove is_field_hom

A field homomorphism is just a ring homomorphism.
This is one trivial tiny step in moving over to bundled homs.

* Fix up nolints.txt

* Process comments from reviews

* Rename lemma
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…y#1778)

* WIP

* feat(algebra/field): remove is_field_hom

A field homomorphism is just a ring homomorphism.
This is one trivial tiny step in moving over to bundled homs.

* Fix up nolints.txt

* Process comments from reviews

* Rename lemma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants