-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(algebra/field_power): fpow is a strict mono #1778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A field homomorphism is just a ring homomorphism. This is one trivial tiny step in moving over to bundled homs.
jcommelin
added
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Dec 4, 2019
jcommelin
added
awaiting-review
The author would like community review of the PR
and removed
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
labels
Dec 5, 2019
fpvandoorn
reviewed
Dec 6, 2019
The Travis build seems to time-out (but without clear reason). I rebased to restart Travis |
fpvandoorn
reviewed
Dec 6, 2019
fpvandoorn
reviewed
Dec 6, 2019
fpvandoorn
approved these changes
Dec 7, 2019
fpvandoorn
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 7, 2019
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…y#1778) * WIP * feat(algebra/field): remove is_field_hom A field homomorphism is just a ring homomorphism. This is one trivial tiny step in moving over to bundled homs. * Fix up nolints.txt * Process comments from reviews * Rename lemma
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…y#1778) * WIP * feat(algebra/field): remove is_field_hom A field homomorphism is just a ring homomorphism. This is one trivial tiny step in moving over to bundled homs. * Fix up nolints.txt * Process comments from reviews * Rename lemma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the perfectoid project.
Depends on #1777.