[Merged by Bors] - chore(data/set/pairwise): split #17880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`finset.disj_Union` is not used in most of mathlib. This PR move most of related things into a new file. This PR also move other things about `set.pairwise` in `data.finset.basic` into `data.finset.pairwise`.
FR-vdash-bot
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
bors bot
pushed a commit
that referenced
this pull request
Dec 21, 2022
This PR moves some lemmas in `data.set.lattice` to `data.set.basic`, `data.set.image`, and `data.set.function`. They are basic enough and do not depend on the set lattice. This also helps #17880 to split `data.set.pairwise` and reduce the dependency of many files. mathlib4 PR: leanprover-community/mathlib4#1109
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
2 tasks
YaelDillies
approved these changes
Feb 22, 2023
|
The conflict vanished. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
This PR will split most of the lemmas in `data.set.pairwise` which are independent of the `data.set.lattice`. It makes a lot of files no longer depend on `data.set.lattice`. [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/port.20progress/near/315072418) mathlib4 PR: leanprover-community/mathlib4#1184 Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
This PR will split most of the lemmas in `data.set.pairwise` which are independent of the `data.set.lattice`. It makes a lot of files no longer depend on `data.set.lattice`. [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/port.20progress/near/315072418) mathlib4 PR: leanprover-community/mathlib4#1184 Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed: |
|
I'm not sure why Bors says it's a linting error and GitHub a build error... bors d+ |
|
✌️ negiizhao can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2023
This PR will split most of the lemmas in `data.set.pairwise` which are independent of the `data.set.lattice`. It makes a lot of files no longer depend on `data.set.lattice`. [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/port.20progress/near/315072418) mathlib4 PR: leanprover-community/mathlib4#1184 Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
1 task
eric-wieser
reviewed
Mar 27, 2023
Comment on lines
-59
to
-60
| alias function.injective_iff_pairwise_ne ↔ function.injective.pairwise_ne _ | ||
|
|
There was a problem hiding this comment.
What happened to this alias?
There was a problem hiding this comment.
It is already declared in logic.pairwise. cf the porting note in mathlib4.
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 27, 2023
Match leanprover-community/mathlib#17880 The new import of `Mathlib.Data.Set.Lattice` in `Mathlib.Data.Finset.Basic` was implied transitively from tactic imports present in Lean 3. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
joelriou
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 30, 2023
Match leanprover-community/mathlib#17880 The new import of `Mathlib.Data.Set.Lattice` in `Mathlib.Data.Finset.Basic` was implied transitively from tactic imports present in Lean 3. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will split most of the lemmas in
data.set.pairwisewhich are independent of thedata.set.lattice. It makes a lot of files no longer depend ondata.set.lattice.Zulip
mathlib4 PR: leanprover-community/mathlib4#1184