[Merged by Bors] - chore: Split data.set.pairwise
#3117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
eric-wieser
reviewed
Mar 27, 2023
eric-wieser
reviewed
Mar 27, 2023
YaelDillies
commented
Mar 27, 2023
| @@ -9,6 +9,7 @@ Authors: Leonardo de Moura, Jeremy Avigad, Minchao Wu, Mario Carneiro | |||
| ! if you have ported upstream changes. | |||
| -/ | |||
| import Mathlib.Data.Multiset.FinsetOps | |||
| import Mathlib.Data.Set.Lattice | |||
There was a problem hiding this comment.
Can we understand why this import is needed here but not in mathlib?
There was a problem hiding this comment.
We should try removing it again with the intermediate backport now in place (once we have a cache)
There was a problem hiding this comment.
Ah, it seems that mathlib3 gets it from these tactic imports:
import tactic.apply
import tactic.nth_rewrite
import tactic.monotonicityMathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
This should give a better mechanism to diff
2 tasks
eric-wieser
reviewed
Mar 27, 2023
semorrison
added
the
blocked-by-other-PR
Parcly-Taxel
added
mathlib3-pair
|
This PR/issue depends on:
|
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
Match leanprover-community/mathlib#17880 The new import of `Mathlib.Data.Set.Lattice` in `Mathlib.Data.Finset.Basic` was implied transitively from tactic imports present in Lean 3. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
data.set.pairwisedata.set.pairwise
joelriou
pushed a commit
that referenced
this pull request
Mar 30, 2023
Match leanprover-community/mathlib#17880 The new import of `Mathlib.Data.Set.Lattice` in `Mathlib.Data.Finset.Basic` was implied transitively from tactic imports present in Lean 3. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match leanprover-community/mathlib#17880
The new import of
Mathlib.Data.Set.LatticeinMathlib.Data.Finset.Basicwas implied transitively from tactic imports present in Lean 3.s ∩ t * s ∪ t ⊆ s * t#1619There's no link to the port dashboard because the file was renamed.